Skip to content

Remove invalid modules loading spinner in contract deploy page #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

Remove invalid modules loading spinner in contract deploy page #5379

merged 1 commit into from
Nov 11, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 11, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on simplifying the conditional rendering logic in the CustomContractForm component by streamlining the check for modules and removing unnecessary JSX elements.

Detailed summary

  • Removed unnecessary conditional rendering for the Spinner and the surrounding div when modules is empty.
  • Simplified the condition to check for modules directly with modules && modules.length > 0.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 4:16pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 11, 2024 4:16pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 11, 2024 4:16pm
wallet-ui ⬜️ Skipped (Inspect) Nov 11, 2024 4:16pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e4b4008

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 11, 2024 15:51 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review November 11, 2024 15:51
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 11, 2024
@codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (a1b518c) to head (e4b4008).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5379   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files        1070     1070           
  Lines       55671    55671           
  Branches     4081     4081           
=======================================
  Hits        25446    25446           
  Misses      29536    29536           
  Partials      689      689
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a1b518c
packages 40.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 167 ms (+42.67% 🔺) 1.1 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 320 ms (-17.38% 🔽) 2.4 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 37 ms (+194.45% 🔺) 134 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (+1241.38% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (0%) 352 ms (0%) 38 ms (+34.54% 🔺) 389 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2024 •
edited
Loading

Merge activity

@MananTank
Remove invalid modules loading spinner in contract deploy page (#5379)
e4b4008 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on simplifying the conditional rendering of the `ModularContractDefaultModulesFieldset` component by removing unnecessary nested ternary operators and improving code readability.

### Detailed summary
- Removed nested ternary operator for rendering `ModularContractDefaultModulesFieldset`.
- Simplified the condition to check if `modules` exists and has length greater than 0.
- Streamlined the rendering logic for better readability.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-11-remove_invalid_modules_loading_spinner_in_contract_deploy_page branch from 4a5d34a to e4b4008 Compare November 11, 2024 16:13
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 16:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 16:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 11, 2024 16:13 Inactive
@graphite-app graphite-app bot merged commit e4b4008 into main Nov 11, 2024
30 of 31 checks passed
@graphite-app graphite-app bot deleted the 11-11-remove_invalid_modules_loading_spinner_in_contract_deploy_page branch November 11, 2024 16:16
@vercel vercel bot temporarily deployed to Production – wallet-ui November 11, 2024 16:17 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 11, 2024 16:17 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 11, 2024 16:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @joaquim-verges